Fix spacing above CTA button in email templates#12399
Open
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Open
Fix spacing above CTA button in email templates#12399officialasishkumar wants to merge 1 commit intogoogle:developfrom
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Conversation
Apply 20px bottom margin to the last body paragraph in the subscription-confirmation and error-email templates, matching the invitation-email template pattern. Previously all paragraphs used a fixed 16px margin which left insufficient space between the body text and the CTA button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
The subscription-confirmation and error-email templates had a fixed
16pxbottom margin on all body paragraphs, resulting in only 16px spacing above the CTA button. The invitation-email template already handled this correctly by applying20pxto the last paragraph.This change applies the same conditional pattern from the invitation template to both affected templates:
foreach ( $body as $index => $paragraph )count( $body ) - 1 === $index ? '20px' : '16px'for the last paragraph's bottom marginThis ensures consistent 20px spacing above the CTA button across all three email templates while keeping the 16px spacing between intermediate paragraphs.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist